integration: return HTTP 404 for unmatched URLs and close remaining browser-gate gaps

Co-authored-by: Cursor <cursoragent@cursor.com>

e2e/helpers.ts

@@ -13,9 +13,13 @@ export function pagePath(routeId: RouteId, locale: AppLocale): string {
   return routePath(routeId, locale);
 }
 
-export async function readHtml(request: APIRequestContext, path: string): Promise<string> {
+export async function readHtml(
+  request: APIRequestContext,
+  path: string,
+  expectedStatus: number,
+): Promise<string> {
   const response = await request.get(path);
-  expect(response.status(), `GET ${path} failed`).toBeLessThan(400);
+  expect(response.status(), `GET ${path} status`).toBe(expectedStatus);
   return response.text();
 }
 
@@ -42,7 +46,8 @@ export async function expectHead(
         ? '/en/missing-route'
         : '/missing-route'
       : pagePath(routeId, locale);
-  const html = await readHtml(request, path);
+  const expectedStatus = routeId === 'notFound' ? 404 : 200;
+  const html = await readHtml(request, path, expectedStatus);
   const metadata = buildRouteMetadata(routeId, locale, SITE_CONTENT_DATA);
 
   expect(html, `${path} title`).toContain(`<title>${metadata.title}</title>`);
@@ -78,11 +83,11 @@ export async function expectHead(
   expect(html).toContain('name="twitter:description"');
 }
 
-export async function expectNoOverflow(page: Page): Promise<void> {
+export async function expectNoOverflow(page: Page, route: string, width: number): Promise<void> {
   const overflow = await page.evaluate(
     () => document.documentElement.scrollWidth <= window.innerWidth + 1,
   );
-  expect(overflow, `horizontal overflow at ${page.url()}`).toBe(true);
+  expect(overflow, `horizontal overflow at ${width}px on ${route}`).toBe(true);
 }
 
 export async function jsonLdGraph(page: Page): Promise<unknown> {

e2e/layout.e2e.ts

@@ -13,11 +13,16 @@ const CHECKED = [
   '/missing-route',
 ];
 
+const VIEWPORTS = [320, 768, 1024, 1440] as const;
+
 test.describe('layout and crawlability', () => {
   test('does not overflow horizontally on checked routes', async ({ page }) => {
+    for (const width of VIEWPORTS) {
+      await page.setViewportSize({ width, height: 900 });
       for (const path of CHECKED) {
         await page.goto(path);
-      await expectNoOverflow(page);
+        await expectNoOverflow(page, path, width);
+      }
     }
   });
 
@@ -33,14 +38,17 @@ test.describe('layout and crawlability', () => {
       seen.add(path);
 
       await page.goto(path);
-      const urls = await page.evaluate(() => {
+      const { urls, baseURI } = await page.evaluate(() => {
         const values = [
           ...Array.from(document.querySelectorAll('a[href]'), (node) => node.getAttribute('href')),
           ...Array.from(document.querySelectorAll('[src]'), (node) => node.getAttribute('src')),
         ];
-        return values.filter(
+        return {
+          baseURI: document.baseURI,
+          urls: values.filter(
             (value): value is string => typeof value === 'string' && value.length > 0,
-        );
+          ),
+        };
       });
 
       for (const raw of urls) {
@@ -48,8 +56,8 @@ test.describe('layout and crawlability', () => {
           continue;
         }
 
-        const resolved = new URL(raw, page.url());
-        if (resolved.origin !== new URL(page.url()).origin) {
+        const resolved = new URL(raw, baseURI);
+        if (resolved.origin !== new URL(baseURI).origin) {
           continue;
         }
 

e2e/seo.e2e.ts

@@ -30,6 +30,14 @@ test.describe('server-rendered metadata', () => {
     }
   });
 
+  test('unmatched URLs return 404 and a real route stays 200', async ({ request }) => {
+    const home = await request.get('/');
+    expect(home.status(), 'GET /').toBe(200);
+
+    await expectHead(request, 'notFound', 'de');
+    await expectHead(request, 'notFound', 'en');
+  });
+
   test('client navigation does not duplicate head tags', async ({ page }) => {
     await page.goto('/');
     await page.locator('a.contact-cta').first().waitFor();

eslint.config.js

@@ -11,8 +11,6 @@ module.exports = tseslint.config(
       '.angular/**',
       'node_modules/**',
       'coverage/**',
-      'e2e/**',
-      'playwright.config.ts',
       'playwright-report/**',
       'test-results/**',
       '.lighthouseci/**',
@@ -20,6 +18,7 @@ module.exports = tseslint.config(
   },
   {
     files: ['**/*.ts'],
+    ignores: ['e2e/**/*.ts', 'playwright.config.ts'],
     extends: [
       eslint.configs.recommended,
       ...tseslint.configs.recommended,
@@ -49,5 +48,15 @@ module.exports = tseslint.config(
     files: ['**/*.html'],
     extends: [...angular.configs.templateRecommended, ...angular.configs.templateAccessibility],
   },
+  {
+    files: ['e2e/**/*.ts', 'playwright.config.ts'],
+    extends: [eslint.configs.recommended, ...tseslint.configs.recommended],
+    languageOptions: {
+      parserOptions: {
+        project: './tsconfig.e2e.json',
+        tsconfigRootDir: __dirname,
+      },
+    },
+  },
   prettier,
 );

src/app/app.routes.server.spec.ts

@@ -0,0 +1,19 @@
+import { RenderMode } from '@angular/ssr';
+import { serverRoutes } from './app.routes.server';
+
+describe('server routes', () => {
+  it('returns HTTP 404 from the catch-all and leaves prerendered routes without a status', () => {
+    const catchAll = serverRoutes.find((route) => route.path === '**');
+
+    expect(catchAll?.renderMode).toBe(RenderMode.Server);
+    expect(catchAll && 'status' in catchAll ? catchAll.status : undefined).toBe(404);
+
+    const prerendered = serverRoutes.filter((route) => route.path !== '**');
+    expect(prerendered.length).toBeGreaterThan(0);
+
+    for (const route of prerendered) {
+      expect(route.renderMode, route.path).toBe(RenderMode.Prerender);
+      expect('status' in route, `${route.path} must not set status`).toBe(false);
+    }
+  });
+});

src/app/app.routes.server.ts

@@ -9,5 +9,6 @@ export const serverRoutes: ServerRoute[] = [
   {
     path: '**',
     renderMode: RenderMode.Server,
+    status: 404,
   },
 ];

tsconfig.e2e.json

@@ -0,0 +1,8 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "outDir": "./out-tsc/e2e",
+    "types": ["node"]
+  },
+  "include": ["e2e/**/*.ts", "playwright.config.ts"]
+}

tsconfig.json

@@ -28,6 +28,9 @@
     },
     {
       "path": "./tsconfig.spec.json"
+    },
+    {
+      "path": "./tsconfig.e2e.json"
     }
   ]
 }